Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1232318 fix account name validation #890

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

SNOW-1232318 Fix account name validation to allow account name be even 1 or 2 chars long

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner March 13, 2024 12:12
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.25%. Comparing base (7ea8366) to head (6949ae9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #890      +/-   ##
==========================================
+ Coverage   84.14%   84.25%   +0.10%     
==========================================
  Files          88       88              
  Lines        9392     9400       +8     
  Branches      885      886       +1     
==========================================
+ Hits         7903     7920      +17     
+ Misses       1256     1248       -8     
+ Partials      233      232       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-knozderko sfc-gh-knozderko merged commit 4d85588 into master Mar 13, 2024
24 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-1232318_account_name_validation branch March 13, 2024 16:39
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants