SNOW-850068: Remove deprecated parser and downloader #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deprecated-parser-and-downloader # Conflicts: # Snowflake.Data.Tests/UnitTests/ChunkDeserializerTest.cs # Snowflake.Data.Tests/UnitTests/ChunkDownloaderFactoryTest.cs # Snowflake.Data.Tests/UnitTests/ChunkParserFactoryTest.cs # Snowflake.Data.Tests/UnitTests/ChunkStreamingParserTest.cs # Snowflake.Data/Core/ChunkDeserializer.cs # Snowflake.Data/Core/ChunkStreamingParser.cs # Snowflake.Data/Core/SFBlockingChunkDownloader.cs # Snowflake.Data/Core/SFChunkDownloaderV2.cs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #770 +/- ##
==========================================
- Coverage 84.46% 84.27% -0.19%
==========================================
Files 92 88 -4
Lines 9576 9327 -249
Branches 891 873 -18
==========================================
- Hits 8088 7860 -228
+ Misses 1257 1241 -16
+ Partials 231 226 -5 ☔ View full report in Codecov by Sentry. |
sfc-gh-knozderko
approved these changes
Feb 15, 2024
sfc-gh-pbulawa
deleted the
SNOW-850068-remove-deprecated-parser-and-downloader
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove deprecated parsers and downloaders.
Checklist
dotnet test)