Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-829489: Fix CLA Assistant Github Action #811

Merged
merged 3 commits into from May 31, 2023
Merged

SNOW-829489: Fix CLA Assistant Github Action #811

merged 3 commits into from May 31, 2023

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

@sfc-gh-pbulawa sfc-gh-pbulawa commented May 30, 2023 •
edited

Description

Fix the CLA bot.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pbulawa sfc-gh-pbulawa marked this pull request as ready for review May 30, 2023 13:38
@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner May 30, 2023 13:38
@sfc-gh-pbulawa
Copy link
Collaborator Author

recheck

sfc-gh-igarish
sfc-gh-igarish approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for looking into it.

@sfc-gh-pbulawa sfc-gh-pbulawa merged commit a81034c into master May 31, 2023
22 of 23 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the cla_bot_fix branch May 31, 2023 19:47
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-dheyman-1 sfc-gh-dheyman-1 Awaiting requested review from sfc-gh-dheyman-1

@sfc-gh-pfus sfc-gh-pfus Awaiting requested review from sfc-gh-pfus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sfc-gh-pbulawa @sfc-gh-igarish