Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing makefiles for example apps #809

Merged
merged 1 commit into from Jun 1, 2023
Merged

Add missing makefiles for example apps #809

merged 1 commit into from Jun 1, 2023

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented May 29, 2023 •
edited

Description

Please explain the changes you made here.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner May 29, 2023 08:09
@sfc-gh-dszmolka
Copy link
Contributor

sfc-gh-dszmolka commented May 30, 2023 •
edited

completes #808

@sfc-gh-dheyman-1
Copy link
Collaborator

sfc-gh-dheyman-1 commented May 30, 2023 •
edited

Shouldn't we update explanation in README.md (## Install sample programs section)?

@sfc-gh-pfus
Copy link
Collaborator Author

Shouldn't we update explanation in README.md (## Install sample programs section)?

Ok, done.

sfc-gh-igarish
sfc-gh-igarish approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pfus sfc-gh-pfus merged commit 88ca05d into master Jun 1, 2023
23 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the makefiles branch June 1, 2023 06:41
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

@sfc-gh-dheyman-1 sfc-gh-dheyman-1 sfc-gh-dheyman-1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sfc-gh-pfus @sfc-gh-dszmolka @sfc-gh-dheyman-1 @sfc-gh-igarish @sfc-gh-pbulawa