SNOW-755844: Pointer datatype *time.Time returns <nil> value #761
+127
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/246
Starting with gosnowflake 1.6.13, the use of a pointer *time.Time type in user-defined structures used to perform updates/inserts has silently stopped working, and nil value is used instead of the value it points to.
This PR fixes the regression introduced by PR #642. All array binding insertion using []interface{} will now be wrapped in the interfaceArrayBinding struct, instead of assuming them as the reflect.Slice and reflect.Struct types.
Checklist
make fmt
to fix inconsistent formatsmake lint
to get lint errors and fix all of them