Revert change to add support for new OKTA OIE #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retry.go
Outdated
| @@ -239,7 +239,7 @@ func (r *retryHTTP) execute() (res *http.Response, err error) { | |||
| logger.WithContext(r.ctx).Warningf( | |||
| "failed http connection. no response is returned. err: %v. retrying...\n", err) | |||
| } else { | |||
| if res.StatusCode == http.StatusOK || r.raise4XX && res != nil && res.StatusCode >= 400 && res.StatusCode < 500 && res.StatusCode != 429 { | |||
| if res.StatusCode == http.StatusOK || r.raise4XX && res != nil && res.StatusCode >= 400 && res.StatusCode < 500 { | |||
There was a problem hiding this comment.
You can keep 429 retry part. There is a separate issue file for it.
sfc-gh-ext-simba-lb
force-pushed
the
revert-731-retryHttpStatusCode429
branch
from
9fe334d
to
1a919a4
Compare
sfc-gh-ext-simba-lb
changed the title
This reverts commit 7c7d86c.
sfc-gh-ext-simba-lb
force-pushed
the
revert-731-retryHttpStatusCode429
branch
from
1a919a4
to
7d6b02f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts #731
(keeping change to retry 429)