Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for new OKTA OIE and retry 429 error code #731

Merged
merged 1 commit into from Feb 28, 2023
Merged

Add support for new OKTA OIE and retry 429 error code #731

merged 1 commit into from Feb 28, 2023

Conversation

sfc-gh-ext-simba-lb
Copy link
Contributor

@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb commented Feb 21, 2023 •
edited

Description

Retry on http error code 429 https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/230

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb force-pushed the retryHttpStatusCode429 branch 2 times, most recently from a73ca2d to 05b6aa4 Compare February 28, 2023 17:05
@sfc-gh-ext-simba-lb
retry 429 error code
959ab6e 
add retry and test for 429
sfc-gh-igarish
sfc-gh-igarish approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb merged commit 7c7d86c into master Feb 28, 2023
@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb deleted the retryHttpStatusCode429 branch February 28, 2023 20:20
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sfc-gh-ext-simba-lb @sfc-gh-igarish