Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rx: optimise item struct #221

Closed
2 tasks
Tracked by #122
plastikfan opened this issue Apr 15, 2024 · 0 comments · Fixed by #223
Closed
2 tasks
Tracked by #122

rx: optimise item struct #221

plastikfan opened this issue Apr 15, 2024 · 0 comments · Fixed by #223
Assignees
@plastikfan
Labels
refactor Refactor code

Comments

@plastikfan
Copy link
Contributor

plastikfan commented Apr 15, 2024 •
edited

  • remove extra fields and define getters on Item
  • move the enum definitions in types, to the enums package.

we will leave the V and E fields as is, as they are the original fields and there is little value in making them use the shared opaque field.
@plastikfan plastikfan mentioned this issue Apr 15, 2024
Open
59 tasks
@plastikfan plastikfan self-assigned this Apr 15, 2024
@plastikfan plastikfan added the refactor Refactor code label Apr 15, 2024
plastikfan added a commit that referenced this issue Apr 15, 2024
@plastikfan
feat(rx): optimise Item struct (#221)
4dfef08 
ref(rx): add opaque getter methods to Item (#221)

ref(rx): remove B from Item (#221)

ref(rx): remove C from Item (#221)

ref(rx): remove N from Item (#221)

ref(rx): remove O from Item (#221)

ref(rx): rename Item.value to aux (#221)

ref(rx): move enum types to enums package (#221)

ref(rx): rename numeric to number (#221)

ref(rx): change pointer receivers on Item (#221)
@plastikfan plastikfan mentioned this issue Apr 15, 2024
Merged
@plastikfan plastikfan linked a pull request Apr 15, 2024 that will close this issue
feat(rx): optimise Item struct (#221) #223
Merged
plastikfan added a commit that referenced this issue Apr 15, 2024
@plastikfan
feat(rx): optimise Item struct (#221)
cb08370 
ref(rx): add opaque getter methods to Item (#221)

ref(rx): remove B from Item (#221)

ref(rx): remove C from Item (#221)

ref(rx): remove N from Item (#221)

ref(rx): remove O from Item (#221)

ref(rx): rename Item.value to aux (#221)

ref(rx): move enum types to enums package (#221)

ref(rx): rename numeric to number (#221)

ref(rx): change pointer receivers on Item (#221)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plastikfan plastikfan

Labels
refactor Refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rx): optimise Item struct (#221) snivilised/lorax
1 participant
@plastikfan