Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or make even more optional the url crate in the next version. #412

Closed
Thomas-airmatrix opened this issue Mar 6, 2024 · 1 comment

Comments

@Thomas-airmatrix
Copy link

Outside of tests there is only a single use of url::Url in tungstenite:

impl<'a> IntoClientRequest for &'a Url {
    fn into_client_request(self) -> Result<Request> {
        self.as_str().into_client_request()
    }
}

impl IntoClientRequest for Url {
    fn into_client_request(self) -> Result<Request> {
        self.as_str().into_client_request()
    }
}

Which is just implementing some helper conversion traits.

Instead, we can just have users call as_str() on the Url directly if needed.

With http =1, http::uri::Uri has replaced most uses of the url crate. I have multiple project such that the only use of url is tungstenite.

@Its-Just-Nans
Copy link
Contributor

Its-Just-Nans commented May 13, 2024

This can be closed ?! (#419)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants