Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display correct payload in Frame::fmt #337

Merged
merged 1 commit into from Feb 12, 2023
Merged

Display correct payload in Frame::fmt #337

merged 1 commit into from Feb 12, 2023

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Feb 11, 2023

Current behavior (example):

2023-02-11T23:09:47.255396Z TRACE tungstenite::protocol::frame: received frame
<FRAME>
final: true
reserved: false false false
opcode: BINARY
length: 45
payload length: 43
payload: 0x8374000464016464036e696c64026f7061b64017364036e696c64017464036e696c

See https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=d306cadb79c84629d4b92b41bbaf8bd6 for how this PR (should) change this output. Big warning that I have not tested this, because the fix seems trivial.

@daniel-abramov daniel-abramov merged commit e1033af into snapview:master Feb 12, 2023
@A5rocks A5rocks deleted the fix-frame-display branch February 12, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants