Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to return input functions from input functions. Such nesting is evaluated 10 times at most. Beyond that, an error is thrown. #2717

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

FelixMoelder
Copy link
Contributor

@FelixMoelder FelixMoelder commented Feb 22, 2024

Description

Snakemake fails building the DAG when a function containing a inner-function is called within an expand-command.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

FelixMoelder and others added 3 commits February 22, 2024 13:57
…h nesting is evaluated 10 times at most. Beyond that, an error is thrown.
@johanneskoester johanneskoester changed the title fix: calling inner function feat: add ability to return input functions from input functions. Such nesting is evaluated 10 times at most. Beyond that, an error is thrown. Feb 23, 2024
Copy link

sonarcloud bot commented Feb 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@johanneskoester johanneskoester merged commit 7a47924 into main Feb 23, 2024
36 checks passed
@johanneskoester johanneskoester deleted the fix/call_inner branch February 23, 2024 15:47
johanneskoester pushed a commit that referenced this pull request Feb 24, 2024
🤖 I have created a release *beep* *boop*
---


##
[8.5.0](v8.4.12...v8.5.0)
(2024-02-24)


### Features

* add ability to return input functions from input functions. Such
nesting is evaluated 10 times at most. Beyond that, an error is thrown.
([#2717](#2717))
([7a47924](7a47924))
* support for report plugins
([#2700](#2700))
([2f7d4b5](2f7d4b5))


### Bug Fixes

* fix wait for files in case of using remote storage and remote
execution ([#2718](#2718))
([eec3a5f](eec3a5f))
* proper interpretation of standard resources given as strings (e.g.
runtime as '5m'). Avoid the need to set additional quotes around size or
timespan resources. Improved error messages for resource handling.
([#2716](#2716))
([b6636e9](b6636e9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants