Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to windows-sys #27

Merged
merged 2 commits into from
Nov 27, 2022
Merged

Port to windows-sys #27

merged 2 commits into from
Nov 27, 2022
+16 −11

Conversation

notgull
Copy link
Member

@notgull notgull commented Nov 26, 2022

The ecosystem is, by and large, migrating away from winapi and moving towards windows-sys. This PR ports the current Windows implementation of process waiting from winapi to windows-sys.

This was referenced Nov 27, 2022
Closed
Closed
taiki-e
taiki-e approved these changes Nov 27, 2022
View reviewed changes
Copy link
Collaborator

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@notgull notgull merged commit de10717 into smol-rs:master Nov 27, 2022
@taiki-e taiki-e mentioned this pull request Nov 27, 2022
Merged
@notgull notgull deleted the windows-sys branch December 8, 2022 21:32
@notgull notgull restored the windows-sys branch December 8, 2022 21:32
@notgull notgull deleted the windows-sys branch December 8, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@notgull @taiki-e