Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy::from_over_into lint #12

Merged
merged 1 commit into from
Apr 24, 2021
Merged

Fix clippy::from_over_into lint #12

merged 1 commit into from
Apr 24, 2021

Conversation

taiki-e
Copy link
Collaborator

@taiki-e taiki-e commented Apr 24, 2021

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> src/tcp.rs:231:1
    |
231 | impl Into<Arc<Async<std::net::TcpListener>>> for TcpListener {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(clippy::from_over_into)]` on by default
    = help: consider to implement `From` instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into

@taiki-e taiki-e merged commit 8888e9a into master Apr 24, 2021
@taiki-e taiki-e deleted the clippy-from_over_into branch April 24, 2021 09:28
@taiki-e taiki-e mentioned this pull request Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant