Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update this crate to use the new polling breaking changes #142

Merged
merged 6 commits into from Sep 10, 2023
Merged

Update this crate to use the new polling breaking changes #142

merged 6 commits into from Sep 10, 2023

Conversation

notgull
Copy link
Member

@notgull notgull commented Jul 11, 2023

For now, this exists as a testing ground in order to test smol-rs/polling#123 before we release it. Consumers of async-io should tell me if this API fits their purposes.

Supersedes #136

@notgull notgull requested review from zeenix and removed request for zeenix July 11, 2023 04:09
@notgull
Copy link
Member Author

notgull commented Jul 11, 2023

(Sorry for the accidental ping, thought this was another issue)

@notgull notgull mentioned this pull request Jul 13, 2023
Merged
fogti
fogti reviewed Jul 13, 2023
View reviewed changes
Cargo.toml Show resolved Hide resolved
@ivmarkov
Copy link
Contributor

ivmarkov commented Aug 14, 2023 •
edited

@notgull wondering if there is any work still open in this PR that precludes it from merging.

As I understand it, we are in a bit of a weird state right now, and probably we don't want to keep it that way for too long:

  • polling mainline is already migrated to the new metaphor
  • async-io still needs this merged, and released versions of async-io currently cannot be patched to work against latest polling mainline, due to the changes in the polling API contract

FWIW, the changes in this branch work fine for me on ESP IDF, but this was not an extensive test in any way.

@notgull
Copy link
Member Author

notgull commented Aug 14, 2023

There are a few more breaking changes that I want to make in polling first.

@ivmarkov ivmarkov mentioned this pull request Aug 16, 2023
Closed
@notgull notgull force-pushed the notgull/polling-breaking-changes branch from 56549d7 to d01748d Compare September 5, 2023 03:53
@notgull notgull marked this pull request as ready for review September 5, 2023 03:53
@notgull
Copy link
Member Author

notgull commented Sep 5, 2023

Now that the new polling is released, this is ready now.

@zeenix
Copy link
Member

zeenix commented Sep 5, 2023

@notgull cool. CI is failing though.

zeenix
zeenix previously requested changes Sep 5, 2023
View reviewed changes
examples/windows-uds.rs Outdated Show resolved Hide resolved
@notgull notgull force-pushed the notgull/polling-breaking-changes branch from d01748d to 2f71173 Compare September 5, 2023 15:29
@notgull
Copy link
Member Author

notgull commented Sep 5, 2023

@notgull cool. CI is failing though.

OpenBSD is failing because criterion bumped to an MSRV that no longer supports the version of Rust that OpenBSD comes with.

@taiki-e
Copy link
Collaborator

taiki-e commented Sep 5, 2023

OpenBSD is failing because criterion bumped to an MSRV that no longer supports the version of Rust that OpenBSD comes with.

Downgrading criterion to 0.4 should fix it. (We already skipped criterion 0.5 on many repositories: smol-rs/piper#1, smol-rs/atomic-waker#17, smol-rs/async-executor#43, smol-rs/concurrent-queue#42, smol-rs/event-listener#62)

fogti
fogti reviewed Sep 6, 2023
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
@notgull notgull requested a review from zeenix September 7, 2023 02:55
taiki-e
taiki-e reviewed Sep 7, 2023
View reviewed changes
examples/windows-uds.rs Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@notgull notgull mentioned this pull request Sep 8, 2023
Closed
fogti
fogti reviewed Sep 9, 2023
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
@notgull notgull mentioned this pull request Sep 9, 2023
Merged
taiki-e
taiki-e reviewed Sep 10, 2023
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
notgull and others added 5 commits September 10, 2023 09:22
@notgull
Port to the new polling
eb6c5a1 
Due to the `uds_window` not supporting I/O safety yet we just drop
support for it for now. In the future it would be nice if it supported
I/O safety.
@notgull
Update for polling v3.0.0
f57d58c 
Signed-off-by: John Nunley <dev@notgull.net>
@notgull
Add more documentation to IoSafe
a0e2f3a 
Signed-off-by: John Nunley <dev@notgull.net>
@notgull
Review comments
a95d00c 
Signed-off-by: John Nunley <dev@notgull.net>
@notgull
Further review comments
c08aa58 
- Fix IoSafe docs
- Remove impls of IoSafe for Rc and Arc

Signed-off-by: John Nunley <dev@notgull.net>
@notgull notgull force-pushed the notgull/polling-breaking-changes branch from dba9139 to c08aa58 Compare September 10, 2023 16:31
taiki-e
taiki-e reviewed Sep 10, 2023
View reviewed changes
Copy link
Collaborator

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@notgull
More review comments
6dc3f2e 
- Mention BufRead in IoSafe docs
- Fix doctest for &T in IoSafe

Signed-off-by: John Nunley <dev@notgull.net>
@notgull notgull dismissed zeenix’s stale review September 10, 2023 20:42

Already approved by other admin

@notgull notgull merged commit 1b1466a into master Sep 10, 2023
21 checks passed
@notgull notgull deleted the notgull/polling-breaking-changes branch September 10, 2023 20:43
This was referenced Sep 11, 2023
Closed
Closed
Closed
@notgull notgull mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sehz sehz sehz left review comments

@fogti fogti fogti approved these changes

@taiki-e taiki-e taiki-e left review comments

@zeenix zeenix Awaiting requested review from zeenix

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@notgull @ivmarkov @zeenix @taiki-e @sehz @fogti