Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use blocking::Task instead of boxing unblock() #23

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Use blocking::Task instead of boxing unblock() #23

merged 1 commit into from
Sep 17, 2023
+6 −5

Conversation

notgull
Copy link
Member

@notgull notgull commented Sep 17, 2023 •
edited
Loading

This saves a heap allocation. Closes #22

@notgull
Use blocking::Task instead of boxing unblock()

Verified

This commit was signed with the committer’s verified signature.
notgull John Nunley
GPG key ID: 397D2B00FEA368AA
Verified
Learn about vigilant mode
1bfc7c3 
This saves a heap allocation.

Signed-off-by: John Nunley <dev@notgull.net>
@notgull notgull merged commit c971597 into master Sep 17, 2023
@notgull notgull deleted the notgull/ub branch September 17, 2023 17:20
@notgull notgull mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use blocking::Task instead of a boxed pinned future
2 participants
@notgull @taiki-e