Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

./gradlew :aws:sdk:assemble fails on Windows for several reasons #3518

Open
Velfi opened this issue Mar 27, 2024 · 0 comments
Open

./gradlew :aws:sdk:assemble fails on Windows for several reasons #3518

Velfi opened this issue Mar 27, 2024 · 0 comments
Labels
bug Something isn't working ops Improves our operations and release process sdk

Comments

@Velfi
Copy link
Contributor

Velfi commented Mar 27, 2024

The crate-hasher crate isn't Windows-compatible. Even after adding a #[cfg(windows)] to fix that, smithyBuild will fail with:

Execution failed for task ':aws:sdk:smithyBuild'.
> Failed to calculate the value of task ':aws:sdk:smithyBuild' property 'outputDir'.
   > Failed to query the value of extension 'smithy' property 'outputDirectory'.
      > Error parsing JSON: Expected valid escape sequence ([33, 46])

This makes it impossible to develop codegen-related code on Windows.
@Velfi Velfi mentioned this issue Mar 27, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 28, 2024
@Velfi
fix the ./gradlew :aws:sdk:assemble command and aws-config tests on…
f97e6f3 
… Windows (#3522)

tracked in issue #3518 

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
@jdisanti jdisanti added ops Improves our operations and release process bug Something isn't working sdk labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ops Improves our operations and release process sdk
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdisanti @Velfi