Implements pancakeswap #1322
Implements pancakeswap #1322
Conversation
|
| "PASTRYPUNKS": "0x1BF571b3d5485109e59d002e9765104e4E238BfD", | ||
| "PTA": "0x3843f234b35a311e195608d32283a68284b3c44d", | ||
| "POR": "0x9000Cac49C3841926Baac5b2E13c87D43e51B6a4", | ||
| "PLG": "0xDAd3ABce6Fb87FA0355203b692723A7EE8aa9D63" |
There was a problem hiding this comment.
How did you compile this list?
I'm a bit hesitant approving this PR when I cannot verify that there aren't any incorrect mappings here. Potentially we can reduce this list to the most common tickers.
| @@ -0,0 +1,69 @@ | |||
| # Chainlink External Adapter for Curve.fi | |||
There was a problem hiding this comment.
This README needs to be updated
| export const ENV_ADDRESS_PROVIDER = 'ADDRESS_PROVIDER' | ||
| export const ENV_BLOCKCHAIN_NETWORK = 'BLOCKCHAIN_NETWORK' |
There was a problem hiding this comment.
These need to be included in README and the schema file
| export const ENV_ADDRESS_PROVIDER = 'ADDRESS_PROVIDER' | ||
| export const ENV_BLOCKCHAIN_NETWORK = 'BLOCKCHAIN_NETWORK' | ||
|
|
||
| export const DEFAULT_BLOCKCHAIN_NETWORK = 'bsc' |
There was a problem hiding this comment.
Let's use the full name. Same goes for preset token addresses.
| export const DEFAULT_BLOCKCHAIN_NETWORK = 'bsc' | |
| export const DEFAULT_BLOCKCHAIN_NETWORK = 'binance-smart-chain' |
|
|
||
| export const DEFAULT_BLOCKCHAIN_NETWORK = 'bsc' | ||
| export const DEFAULT_ENDPOINT = 'crypto' | ||
| export const ROUTER_CONTRACT = '0x10ED43C718714eb63d5aA57B78B54704E256024E' |
There was a problem hiding this comment.
Is this configurable in any way?
| beforeAll(async () => { | ||
| server = await startServer() | ||
| req = request(`localhost:${(server.address() as AddressInfo).port}`) | ||
| process.env.CACHE_ENABLED = 'false' |
There was a problem hiding this comment.
We should aim to have all new adapters work without this set
| process.env.CACHE_ENABLED = 'false' |
|
Hey @lucaswxp, are you interested in getting this PR updated, or should we close this PR? |
|
Closing this PR for now, but feel free to re-open once it's ready for re-review! |
Closes #824
Description
......
Steps to Test
This will update snapshot, be careful. Some times timeouts may occur due to network slowdown, just try again.
Quality Assurance
<ADAPTER_PACKAGE>/schemas/env.jsonand<ADAPTER_PACKAGE>/README.mdinfra-k8sconfiguration file.feature/x,chore/x,release/x,hotfix/x,fix/x) or is created from Clubhouse/Shortcut