Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all adapters are using newest patterns #1471

Open
justinkaseman opened this issue Jan 19, 2022 · 3 comments
Open

Ensure all adapters are using newest patterns #1471

justinkaseman opened this issue Jan 19, 2022 · 3 comments
Assignees

Comments

@justinkaseman
Copy link
Member

**There are adapters that exist in the mono-repo that may be missing some of the following:

  • using the file structure shown in the example source adapter with /endpoints folder
  • using endpointSelector patterns seen in adapter.ts
  • using module exports
  • exporting their package specific types

They should be migrated to the newer style (see example adapters)**
https://github.com/smartcontractkit/external-adapters-js/tree/develop/packages/examples/source

@austinborn
Copy link
Contributor

Are there specific examples of lack of module exports, or missing package type exports? The first two are clear and generally-applicable, but I don't know what the requirements are for the last two.

@austinborn
Copy link
Contributor

austinborn commented Jan 28, 2022

Progress for endpoints folder and endpointSelector pattern will be tracked here:
https://docs.google.com/spreadsheets/d/1JZMADFZxihNOVHmmfZDCHa8IzsjlGgt9yemEWfMsd7U/edit#gid=0

@austinborn
Copy link
Contributor

@bogos @karen-stepanyan For now, only worry about the endpoints folder and endpointSelector pattern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants