Add 'Serial' struct method returning serial number directly from Yubi… #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
maraino
requested changes
Mar 25, 2024
kms/yubikey/yubikey.go
Outdated
Comment on lines
363
to
369
| func (k *YubiKey) Serial() string { | ||
| if serial, err := k.yk.Serial(); err == nil { | ||
| return strconv.FormatUint(uint64(serial), 10) | ||
| } | ||
|
|
||
| return "" | ||
| } |
There was a problem hiding this comment.
You should return an error, wrapping it with something like:
fmt.Errorf("error getting Yubikey's serial number: %w", err)
maraino
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Key.
This change provides a public struct method to obtain the serial number of a Yubikey directly from the the device; in the
pivpackage this employs the native PIV instruction with a fallback for older models.This enables client code using this library to always get the device serial number, even if the attestation key/certificate has been evicted/imported over.
💔Thank you!