Add store and load certificates in mackms #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for loading and storing simple certificates using LoadCertificate and StoreCertificate
This commit adds to mackms the methods LoadCertificateChain, StoreCertificateChain, and DeleteCertificate.
hslatman
reviewed
Mar 18, 2024
Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
hslatman
reviewed
Mar 19, 2024
|
Really small thing, but otherwise looks good |
Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
maraino
force-pushed
the
mariano/mackms-certs
branch
from
3a9d874
to
69660dc
Compare
hslatman
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for loading and storing simple certificates using LoadCertificate and StoreCertificate, LoadCertificateChain, StoreCertificateChain, and the experimental DeleteCertificate.
For future PRs we can add support for (cc: @joshdrake):
Other options would be easy support for updating certificates, SecPKCS12Import, and importing private keys.