Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AK-only attestation through CreateAttestation #267

Merged
merged 2 commits into from Jun 20, 2023

Conversation

hslatman
Copy link
Member

@hslatman hslatman commented Jun 19, 2023

Before this PR AK attestation only worked for cases in which a (valid) AK certificate chain was already available, or when a new attestation was requested for a key attested by the AK. This PR adds support for obtaining an AK certificate for an AK if addressed directly (e.g. tpmkms:name=my-ak;ak=true) instead of addressing a key.

When `CreateAttestation` is called for an AK, and no (valid) AK
certificate chain is present, perform the attestation flow.
Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think we can clarify a little bit the flow, see my comment.

kms/tpmkms/tpmkms.go Show resolved Hide resolved
Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kms/tpmkms/tpmkms.go Show resolved Hide resolved
@hslatman hslatman merged commit 02557c0 into master Jun 20, 2023
14 of 15 checks passed
@hslatman hslatman deleted the herman/tpmkms-ak-attestation branch June 20, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants