Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle plugin: Add mandatory dependency to smallrye-config #1425

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

snazy
Copy link
Contributor

@snazy snazy commented Mar 24, 2023

Using the Gradle plugin (v3.3.1) otherwise leads to

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':nessie-model:generateOpenApiSpec'.
> io/smallrye/config/SmallRyeConfigBuilder

which is a ClassNotFoundException.

Fixes #1426

Using the Gradle plugin (v3.3.1) otherwise leads to
```
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':nessie-model:generateOpenApiSpec'.
> io/smallrye/config/SmallRyeConfigBuilder
```
which is a `ClassNotFoundException`.
@MikeEdgar
Copy link
Member

Thank you for fixing this. Why is it that the Gradle dependency for config is not enough?

@snazy
Copy link
Contributor Author

snazy commented Mar 24, 2023

The pom generated by Gradle is fine. It’s just that Maven overwrites it (or prefers it’s own one).

@snazy snazy closed this Mar 24, 2023
@snazy snazy reopened this Mar 24, 2023
@snazy
Copy link
Contributor Author

snazy commented Mar 24, 2023

(Fat-finger close/open issue)

@snazy
Copy link
Contributor Author

snazy commented Mar 24, 2023

Gradle would publish its own Pom to plugins.gradle.org, but it’s still better to keep both in sync, since users could prefer to pull Gradle plug-ins from Maven Central (we did that when Gradle‘s plugin repo was a bit unreliable).

@MikeEdgar
Copy link
Member

Gradle would publish its own Pom to plugins.gradle.org, but it’s still better to keep both in sync, since users could prefer to pull Gradle plug-ins from Maven Central (we did that when Gradle‘s plugin repo was a bit unreliable).

I'm admittedly ignorant about the Gradle ecosystem, unfortunately. I didn't realize there was crossover between the two like that. I'll go ahead any merge this one, thanks again.

@MikeEdgar MikeEdgar merged commit 15c2cbf into smallrye:main Mar 24, 2023
@MikeEdgar MikeEdgar added this to the 3.3.2 milestone Mar 24, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@snazy snazy deleted the fix-gradle-plugin-deps branch March 24, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle plugin broken in v3.3.1
2 participants