Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SchemaRegistry depends on Jackson #1417

Closed
tjquinno opened this issue Mar 23, 2023 · 1 comment · Fixed by #1418
Closed

SchemaRegistry depends on Jackson #1417

tjquinno opened this issue Mar 23, 2023 · 1 comment · Fixed by #1418
Assignees
Milestone

Comments

@tjquinno
Copy link
Contributor

The earlier addition of AnnotationScannerExtension and delegation to it from key points allows the use of parsers other than Jackson in multiple places.

SchemaRegistry is one place that still has a hard dependency on Jackson:

It would be great for SchemaRegistry also to delegate to an extension for schema parsing.

I know that OpenApiConfig allows me to pass my own custom schema registry, but I don't really want to re-implement SchemaRegistry or change its behavior except for its choice of parser.

(I have not looked through the codebase for other lingering direct reliance on Jackson's parsing.)

@MikeEdgar
Copy link
Member

It looks like we'll need to add a Schema parseSchema(String value) to AnnotationScannerExtension

MikeEdgar added a commit to MikeEdgar/smallrye-open-api that referenced this issue Mar 23, 2023
Fixes smallrye#1417

Signed-off-by: Michael Edgar <michael@xlate.io>
@MikeEdgar MikeEdgar self-assigned this Mar 23, 2023
@MikeEdgar MikeEdgar added this to the 3.3.1 milestone Mar 23, 2023
MikeEdgar added a commit to MikeEdgar/smallrye-open-api that referenced this issue Mar 23, 2023
Fixes smallrye#1417

Signed-off-by: Michael Edgar <michael@xlate.io>
MikeEdgar added a commit to MikeEdgar/smallrye-open-api that referenced this issue Mar 23, 2023
Fixes smallrye#1417

Signed-off-by: Michael Edgar <michael@xlate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants