Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation fails with updated maven-compiler-plugin #1470

Closed
dmlloyd opened this issue Dec 19, 2023 · 2 comments · Fixed by #1471
Closed

Compilation fails with updated maven-compiler-plugin #1470

dmlloyd opened this issue Dec 19, 2023 · 2 comments · Fixed by #1471
Labels
bug Something isn't working ci/cd/build CI/CD pipeline and build
Milestone

Comments

@dmlloyd
Copy link

dmlloyd commented Dec 19, 2023

Context

As part of the smallrye-parent pull request CI, we build and test smallrye-mutiny.

Description

When upgrading maven-compiler-plugin to 3.12.0, the Mutiny build fails:

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for SmallRye Mutiny - Parent 999-SNAPSHOT:
[INFO] 
[INFO] SmallRye Mutiny - Parent ........................... SUCCESS [  2.666 s]
[INFO] SmallRye Mutiny - Testing utilities ................ SUCCESS [  3.772 s]
[INFO] SmallRye Mutiny - Core library ..................... SUCCESS [08:32 min]
[INFO] SmallRye Mutiny - Tests against the Reactive Streams TCK SUCCESS [03:40 min]
[INFO] SmallRye Mutiny - Integration with RxJava 3 ........ SUCCESS [  6.920 s]
[INFO] SmallRye Mutiny - Integration with Reactor ......... SUCCESS [ 12.057 s]
[INFO] SmallRye Mutiny - Integration with SmallRye Context Propagation SUCCESS [  2.492 s]
[INFO] SmallRye Mutiny - MicroProfile Reactive Streams Operators implementation SUCCESS [01:24 min]
[INFO] SmallRye Mutiny - MicroProfile Reactive Streams Operators 3.x implementation SUCCESS [01:22 min]
[INFO] SmallRye Mutiny - Kotlin Extensions ................ FAILURE [  0.442 s]
[INFO] SmallRye Mutiny - Documentation .................... SKIPPED
[INFO] SmallRye Mutiny - BOM .............................. SKIPPED
[INFO] SmallRye Mutiny - Math operators ................... SKIPPED
[INFO] SmallRye Mutiny - Workshop examples ................ SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  15:28 min
[INFO] Finished at: 2023-12-19T05:52:08Z
[INFO] ------------------------------------------------------------------------
Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.12.0:compile (default-compile) on project mutiny-kotlin: Fatal error compiling: basedir /home/runner/work/smallrye-parent/smallrye-parent/smallrye-mutiny/kotlin/target/generated-sources/annotations does not exist -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
Error:  
Error:  After correcting the problems, you can resume the build with the command
Error:    mvn <args> -rf :mutiny-kotlin
Error: Process completed with exit code 1.

Additional details

This is the link to the build failure in CI: https://github.com/smallrye/smallrye-parent/actions/runs/7257824786/job/19772186757?pr=461

See also smallrye/smallrye-parent#461.

@jponge
Copy link
Member

jponge commented Dec 19, 2023

We aren't doing anything fancy except that the Java and Kotlin plugins co-exist in the mutiny-kotlin submodule.

I have a PR coming to disable the Java plugin in this module, but this still looks like a breaking change from the maven-compiler-plugin side, or a misconfiguration somewhere in our inheritance chain as it looks for a folder that doesn't exist.

jponge added a commit that referenced this issue Dec 19, 2023
This fixes a compilation failure when upgrading to version 3.12.0
of the maven-compiler-plugin.

Fixes #1470
@jponge jponge added bug Something isn't working ci/cd/build CI/CD pipeline and build labels Dec 19, 2023
@jponge jponge added this to the 2.5.4 milestone Dec 19, 2023
@dmlloyd
Copy link
Author

dmlloyd commented Dec 19, 2023

The GitHub compatibility report for the updated compiler plugin gives only 70% unfortunately, so some breakage is expected. But, that's why we have CI. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci/cd/build CI/CD pipeline and build
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants