Generate all mappings binding code #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radcortez
force-pushed
the
mappings-all-build-time-generator
branch
2 times, most recently
from
407a4a6
to
2b46c01
Compare
radcortez
force-pushed
the
mappings-all-build-time-generator
branch
2 times, most recently
from
83b6b15
to
c408d1a
Compare
|
@dmlloyd this is quite a big PR, but I think it would be hard to make it incrementally. The main goal was to remove all the runtime introspection code and mapping functions and make everything generated instead. I plan to provide some performance measurements, but early testing seems to indicate an improvement in allocation and CPU time. |
radcortez
force-pushed
the
mappings-all-build-time-generator
branch
from
c408d1a
to
a2a1d3c
Compare
dmlloyd
previously approved these changes
Dec 21, 2023
radcortez
force-pushed
the
mappings-all-build-time-generator
branch
from
a2a1d3c
to
8b0689d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote @ConfigMapping internal implementation to remove the runtime introspection and runtime functions. Required information can be extracted by build time runtimes and fed directly into the builder to reduce runtime operations.