Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from maven-artifact to maven-resolver version scheme #268

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

dmlloyd
Copy link
Collaborator

@dmlloyd dmlloyd commented Dec 6, 2023

Fixes #267

// #267
checkMavenConsistency("3.6.0.CR1", "3.6.0");
checkMavenConsistency("3.6.0.FINAL", "3.6.0");
checkMavenConsistency("3.6.0.SP1", "3.6.0");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will SP1 come before or after 3.6.0?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR1 comes before zero, FINAL is equal to zero, and SP1 is greater than zero.

@dmlloyd dmlloyd merged commit b735271 into smallrye:main Dec 7, 2023
4 checks passed
@dmlloyd dmlloyd deleted the version branch December 7, 2023 15:36
@github-actions github-actions bot added this to the 2.2.1 milestone Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.6.0.CR1 considered newer than 3.6.0
3 participants