Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: v2.0.0: update tags #3583

Merged
merged 1 commit into from Apr 22, 2024

Conversation

ramonpetgrave64
Copy link
Collaborator

@ramonpetgrave64 ramonpetgrave64 commented Apr 22, 2024

#label:release v2.0.0

Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
@ramonpetgrave64
Copy link
Collaborator Author

ramonpetgrave64 commented Apr 22, 2024

references test is failing , as expected.. This should not be failing, because it is meant to be skipped.

https://github.com/slsa-framework/slsa-github-generator/actions/runs/8788176646/job/24115061279?pr=3583#step:4:5

Run ./__THIS_REPO__/.github/workflows/scripts/pre-submit.actions/references.sh
Some Actions are not referenced at main
.github/workflows/delegator_generic_slsa3.yml:        uses: slsa-framework/slsa-github-generator/.github/actions/rng@v2.0.0
.github/workflows/delegator_generic_slsa3.yml:        uses: slsa-framework/slsa-github-generator/.github/actions/verify-token@v2.0.0
.github/workflows/delegator_generic_slsa3.yml:        uses: slsa-framework/slsa-github-generator/.github/actions/secure-upload-artifact@v2.0.0
....

We will change the references to main, in a later step
https://github.com/slsa-framework/slsa-github-generator/blob/main/RELEASE.md#reference-actions-at-main

@ramonpetgrave64 ramonpetgrave64 marked this pull request as ready for review April 22, 2024 17:32
@ramonpetgrave64 ramonpetgrave64 enabled auto-merge (squash) April 22, 2024 17:32
@ramonpetgrave64
Copy link
Collaborator Author

ramonpetgrave64 commented Apr 22, 2024

@kpk47

@ramonpetgrave64 ramonpetgrave64 changed the title #label:release v2.0.0 chore: v2.0.0: update tags Apr 22, 2024
auto-merge was automatically disabled April 22, 2024 19:48

Pull request was closed

@ramonpetgrave64
Copy link
Collaborator Author

Now passing after fixing the PR description, and also closing and re-opening the PR.

https://github.com/slsa-framework/slsa-github-generator/actions/runs/8789987007/job/24120997500?pr=3583

@ramonpetgrave64 ramonpetgrave64 merged commit 5a775b3 into slsa-framework:main Apr 22, 2024
145 of 150 checks passed
@ramonpetgrave64
Copy link
Collaborator Author

tracking in #3576

@ramonpetgrave64 ramonpetgrave64 deleted the v2.0.0 branch April 22, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants