Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create pull_request_template.md #3268

Merged
merged 6 commits into from Feb 22, 2024

Conversation

ramonpetgrave64
Copy link
Collaborator

Adds a PR template as default PR description:

Hopefully this can also remind us to to keep docs up-to-date, as well, like in #3263

Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
@ramonpetgrave64
Copy link
Collaborator Author

@ianlewis @laurentsimon

Copy link
Member

@ianlewis ianlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this so quickly!

.github/pull_request_template.md Outdated Show resolved Hide resolved
ramonpetgrave64 and others added 4 commits February 21, 2024 11:47
Co-authored-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
Copy link
Collaborator

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@laurentsimon laurentsimon merged commit a66d8c0 into slsa-framework:main Feb 22, 2024
74 checks passed
ramonpetgrave64 added a commit to ramonpetgrave64/slsa-github-generator that referenced this pull request Feb 28, 2024
Adds a PR template as default PR description:

Hopefully this can also remind us to to keep docs up-to-date, as well,
like in slsa-framework#3263

---------

Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Co-authored-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
ramonpetgrave64 added a commit that referenced this pull request Mar 20, 2024
ramonpetgrave64 added a commit that referenced this pull request Mar 20, 2024
ramonpetgrave64 added a commit that referenced this pull request Mar 20, 2024
This reverts commit a66d8c0.

Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants