Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] The specified go version file at: go.mod does not exist #2661

Closed
ianlewis opened this issue Aug 19, 2023 · 5 comments · Fixed by #2672
Closed

[bug] The specified go version file at: go.mod does not exist #2661

ianlewis opened this issue Aug 19, 2023 · 5 comments · Fixed by #2672
Labels
area:go Issue related to the Go ecosystem type:bug Something isn't working

Comments

@ianlewis
Copy link
Member

The go-version-file input to the Go builder passes the value to setup-go but since the project is checked out to a different directory than the GITHUB_WORKSPACE setup-go will fail to find the file.

The path given to setup-go needs to be joined with inputs.path where the project is checked out in secure-project-checkout.

go-version-file: ${{ inputs.go-version-file }}

@ianlewis ianlewis added type:bug Something isn't working area:go Issue related to the Go ecosystem labels Aug 19, 2023
@laurentsimon
Copy link
Collaborator

laurentsimon commented Aug 20, 2023

@raghavkaul is this the problem you encountered on scorecard a couple weeks back?

Let's create e2e test for this one, if we don't have one already. I can squeeze this fix in the next release (this week)

laurentsimon added a commit that referenced this issue Sep 5, 2023
blocked on
#2682
closes
#2661

---------

Signed-off-by: laurentsimon <laurentsimon@google.com>
Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Co-authored-by: Ian Lewis <ianlewis@google.com>
@OpenWaygate
Copy link

OpenWaygate commented Feb 18, 2024

I still encounter this bug with v1.9.0, even if I have go.mod in project root.

    uses: slsa-framework/slsa-github-generator/.github/workflows/builder_go_slsa3.yml@v1.9.0
    with:
      go-version-file: go.mod

image

@OpenWaygate
Copy link

Seems that the fixing code is not contained in v1.9.0

@ianlewis
Copy link
Member Author

Seems that the fixing code is not contained in v1.9.0

Yes, this still hasn't been released :(

@laurentsimon
Copy link
Collaborator

We plan to release very soon. /cc @ramonpetgrave64 We have one or two more issues to address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:go Issue related to the Go ecosystem type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants