Dev Chores #130
Dev Chores #130
Conversation
- Migrate to pyproject.toml - Migrate to ruff - Update release workflow
| - run: python -m pip install tox | ||
| - run: python -m tox -e ${{ matrix.tox }} | ||
| build: | ||
| if: startsWith(github.ref, 'refs/tags') |
There was a problem hiding this comment.
@sloria it's better to build the dists unconditionally so that any problems show up early, not last minute, during the release. Also, it's useful to add twine check --strict. My action that you use for publishing, runs metadata linting so it can be unpleasant to get the release fail on the very last step. This would help keep the metadata healthy.
| - uses: actions/setup-python@v4.7.0 | ||
| with: | ||
| python-version: "3.11" | ||
| - run: python -m pip install --upgrade pip |
There was a problem hiding this comment.
Updating pip isn't really needed since tox manages its virtualenvs separately. Dropping this would save some CPU cycles.
| - run: python -m tox -e lint | ||
| publish-to-pypi: | ||
| name: PyPI release | ||
| if: startsWith(github.ref, 'refs/tags/') |
There was a problem hiding this comment.
Branch protection tip: it's possible to integrate https://github.com/marketplace/actions/alls-green#why (shameless plug) and you won't have to remember to update the branch protection rule every time you change the test matrix.
| @@ -1,4 +1,4 @@ | |||
| Copyright 2022 Steven Loria | |||
| Copyright 2024 Steven Loria | |||
There was a problem hiding this comment.
|
Thanks for the feedback @webknjaz . I'll process your comments once I'm back home from vacation |
closes #127