Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow Text as VClick's top-level child (#1214) #1285

Merged
merged 4 commits into from
Feb 11, 2024

Conversation

kermanx
Copy link
Member

@kermanx kermanx commented Feb 11, 2024

fix #1214

This PR wraps VClick's top-level text node child into a span, or other element specified by the wrapText prop.

Now, the following click animations work properly.

<v-click> 123 </v-click>

<v-click :wrap-text="v=>h('div', v)">
0 <del>2</del>
</v-click>

abcd <v-click>_d_ ef</v-click> ghi <v-click>j**kl**</v-click>

@antfu antfu merged commit 1fe6120 into slidevjs:main Feb 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<v-click> component not working
2 participants