fix: codemirror
import error (#1281)
#1283
Merged
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1281
This PR fixes #1281 by partly reverts 4ef7fc9.
It is confusing that the
codemirror
package isn't explicitly excluded fromoptimizeDeps
, but it is in fact not optimized (only when@slidev/cli
and@slidev/client
are installed from npm registry. In this monorepo, it is OK). Andcodemirror@5
is a UMD package, but it is then wrongly imported as an ESM package, which causes the issue. This PR re-addscodemirror
related packages tooptimizeDeps.include
array, and importCodeMirror
as default import.I am not sure whether other packages removed from the
include
list by 4ef7fc9 (listed below) should be added again or not.Lines removed in 4ef7fc9:
This PR re-adds these: