Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squizlabs/PHP_CodeSniffer is abandoned #1640

Closed
LordSimal opened this issue Dec 1, 2023 · 5 comments · Fixed by #1641
Closed

squizlabs/PHP_CodeSniffer is abandoned #1640

LordSimal opened this issue Dec 1, 2023 · 5 comments · Fixed by #1641
Labels

Comments

@LordSimal
Copy link
Contributor

See squizlabs/PHP_CodeSniffer#3932

Will this package switch to https://github.com/PHPCSStandards/PHP_CodeSniffer as it is a direct fork?

@kukulich
Copy link
Contributor

kukulich commented Dec 1, 2023

Yes.

@bkdotcom
Copy link
Contributor

bkdotcom commented Dec 1, 2023

@kukulich
Should a new maintenance release be created?
My repo requires both phpcsstandards/php_codesniffer and slevomat/coding-standard
if I were to composer install now, composer would puill a version of slevomat that also includes the old squizlabs

@jrfnl
Copy link
Contributor

jrfnl commented Dec 2, 2023

@bkdotcom As per the announcement:

Note: I would recommend waiting to make the switch until the 3.8.0 release has been tagged. Watch releases on the new repo to automatically get notified of this. The changelog will contain the relevant information for making the switch.

Until a release has been tagged from the new repo with the replace directive in the composer.json, things won't work as expected as the files in the vendor/bin won't be replaced.

@jrfnl
Copy link
Contributor

jrfnl commented Dec 6, 2023

Update: looks like the Composer package name may not change after all. See this comment and the ones below it and PHPCSStandards/PHP_CodeSniffer#135

Copy link

github-actions bot commented Jan 7, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants