Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add context to rate-limited event #1637

Merged
merged 1 commit into from Aug 2, 2023
Merged

feat: add context to rate-limited event #1637

merged 1 commit into from Aug 2, 2023

Conversation

levenleven
Copy link
Contributor

Summary

Add api request url and body to WebClientEvent.RATE_LIMITED event parameters

Resolves #1636

Requirements (place an x in each [ ])

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @levenleven to sign the Salesforce Inc. Contributor License Agreement.

@seratch seratch added enhancement M-T: A feature request for new functionality pkg:web-api applies to `@slack/web-api` labels Jul 31, 2023
@seratch seratch added this to the web-api@6.9.0 milestone Jul 31, 2023
seratch
seratch approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This enhancement makes a lot of sense and it's not a breaking chance. Since this PR contains a document change, we should merge right before releasing the next minor version

@seratch
Copy link
Member

seratch commented Jul 31, 2023

The CI build error needs to be resolved before merging this PR #1638

@levenleven levenleven mentioned this pull request Jul 31, 2023
Merged
2 tasks
filmaj
filmaj approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and thanks for the tests!

@filmaj filmaj merged commit 2d31f2e into slackapi:main Aug 2, 2023
5 checks passed
@filmaj
Copy link
Contributor

filmaj commented Aug 2, 2023

I am going to cut a release of this package now.

@levenleven levenleven deleted the rate-limit-context branch August 2, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seratch seratch seratch approved these changes

@filmaj filmaj filmaj approved these changes

Assignees
No one assigned
Labels
cla:signed enhancement M-T: A feature request for new functionality pkg:web-api applies to `@slack/web-api` semver:minor
Projects
None yet
Milestone
web-api@6.9.0
Development

Successfully merging this pull request may close these issues.

Provide some context with rate-limited event
3 participants
@levenleven @seratch @filmaj