Skip to content

Commit b284994

Browse files
author
Fil Maj
authoredJul 4, 2024··
web-api(fix): revert use of export type * to maintain backwards compatibility with TS 4.7 (#1841)
·
@slack/webhook@7.0.5@slack/cli-hooks@1.1.1
1 parent e678aff commit b284994

File tree

6 files changed

+88
-43
lines changed

6 files changed

+88
-43
lines changed
 

‎packages/web-api/.gitignore

+3
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,6 @@ package-lock.json
88
# coverage
99
/.nyc_output
1010
/coverage
11+
12+
# test fixtures
13+
test/integration/**/dist

‎packages/web-api/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@
3939
"lint": "eslint --fix --ext .ts src",
4040
"mocha": "mocha --config .mocharc.json src/*.spec.js",
4141
"test": "npm run lint && npm run test:types && npm run test:integration && npm run test:unit",
42-
"test:integration": "npm run build && node test/integration/commonjs-project/index.js && node test/integration/esm-project/index.mjs",
42+
"test:integration": "npm run build && node test/integration/commonjs-project/index.js && node test/integration/esm-project/index.mjs && npm run test:integration:ts",
43+
"test:integration:ts": "cd test/integration/ts-4.7-project && npm i && npm run build",
4344
"test:unit": "npm run build && c8 npm run mocha",
4445
"test:types": "tsd",
4546
"ref-docs:model": "api-extractor run",

‎packages/web-api/src/types/request/index.ts

+42-42
Original file line numberDiff line numberDiff line change
@@ -1,42 +1,42 @@
1-
export type * from './workflows';
2-
export type * from './views';
3-
export type * from './users';
4-
export type * from './tooling';
5-
export type * from './search';
6-
export type * from './usergroups';
7-
export type * from './team';
8-
export type * from './stars';
9-
export type * from './rtm';
10-
export type * from './reminders';
11-
export type * from './reactions';
12-
export type * from './pins';
13-
export type * from './openid';
14-
export type * from './oauth';
15-
export type * from './migration';
16-
export type * from './files';
17-
export type * from './emoji';
18-
export type * from './dnd';
19-
export type * from './dialog';
20-
export type * from './conversations';
21-
export type * from './chat';
22-
export type * from './canvas';
23-
export type * from './calls';
24-
export type * from './bots';
25-
export type * from './bookmarks';
26-
export type * from './auth';
27-
export type * from './apps';
28-
export type * from './api';
29-
export type * from './admin/analytics';
30-
export type * from './admin/apps';
31-
export type * from './admin/auth';
32-
export type * from './admin/barriers';
33-
export type * from './admin/conversations';
34-
export type * from './admin/emoji';
35-
export type * from './admin/functions';
36-
export type * from './functions';
37-
export type * from './admin/inviteRequests';
38-
export type * from './admin/roles';
39-
export type * from './admin/teams';
40-
export type * from './admin/usergroups';
41-
export type * from './admin/users';
42-
export type * from './admin/workflows';
1+
export type { WorkflowsStepCompletedArguments, WorkflowsStepFailedArguments, WorkflowsUpdateStepArguments } from './workflows';
2+
export type { ViewsUpdateArguments, ViewsOpenArguments, ViewsPushArguments, ViewsPublishArguments } from './views';
3+
export type { UsersConversationsArguments, UsersDiscoverableContactsLookupArguments, UsersInfoArguments, UsersListArguments, UsersIdentityArguments, UsersSetPhotoArguments, UsersProfileGetArguments, UsersProfileSetArguments, UsersDeletePhotoArguments, UsersGetPresenceArguments, UsersSetPresenceArguments, UsersLookupByEmailArguments } from './users';
4+
export type { ToolingTokensRotateArguments } from './tooling';
5+
export type { SearchAllArguments, SearchFilesArguments, SearchMessagesArguments } from './search';
6+
export type { UsergroupsCreateArguments, UsergroupsDisableArguments, UsergroupsEnableArguments, UsergroupsListArguments, UsergroupsUpdateArguments, UsergroupsUsersListArguments, UsergroupsUsersUpdateArguments } from './usergroups';
7+
export type { TeamAccessLogsArguments, TeamBillableInfoArguments, TeamBillingInfoArguments, TeamExternalTeamsDisconnectArguments, TeamExternalTeamsListArguments, TeamInfoArguments, TeamIntegrationLogsArguments, TeamPreferencesListArguments, TeamProfileGetArguments } from './team';
8+
export type { StarsAddRemoveArguments, StarsListArguments } from './stars';
9+
export type { RTMConnectArguments, RTMStartArguments } from './rtm';
10+
export type { RemindersAddArguments, RemindersInfoArguments, RemindersListArguments, RemindersDeleteArguments, RemindersCompleteArguments } from './reminders';
11+
export type { ReactionsAddArguments, ReactionsGetArguments, ReactionsListArguments, ReactionsRemoveArguments } from './reactions';
12+
export type { PinsAddArguments, PinsListArguments, PinsRemoveArguments } from './pins';
13+
export type { OpenIDConnectTokenArguments, OpenIDConnectUserInfoArguments } from './openid';
14+
export type { OAuthAccessArguments, OAuthV2AccessArguments, OAuthV2ExchangeArguments } from './oauth';
15+
export type { MigrationExchangeArguments } from './migration';
16+
export type { FilesDeleteArguments, FilesInfoArguments, FilesListArguments, FilesRevokePublicURLArguments, FilesSharedPublicURLArguments, FilesUploadArguments, FilesUploadV2Arguments, FilesCompleteUploadExternalArguments, FilesGetUploadURLExternalArguments, FilesCommentsDeleteArguments, FilesRemoteUpdateArguments, FilesRemoteRemoveArguments, FilesRemoteShareArguments, FilesRemoteListArguments, FilesRemoteInfoArguments, FilesRemoteAddArguments } from './files';
17+
export type { EmojiListArguments } from './emoji';
18+
export type { DndEndDndArguments, DndEndSnoozeArguments, DndInfoArguments, DndSetSnoozeArguments, DndTeamInfoArguments } from './dnd';
19+
export type { DialogOpenArguments } from './dialog';
20+
export type { ConversationsAcceptSharedInviteArguments, ConversationsApproveSharedInviteArguments, ConversationsArchiveArguments, ConversationsCloseArguments, ConversationsCreateArguments, ConversationsDeclineSharedInviteArguments, ConversationsExternalInvitePermissionsSetArguments, ConversationsHistoryArguments, ConversationsInfoArguments, ConversationsInviteArguments, ConversationsInviteSharedArguments, ConversationsJoinArguments, ConversationsKickArguments, ConversationsLeaveArguments, ConversationsListArguments, ConversationsListConnectInvitesArguments, ConversationsMarkArguments, ConversationsMembersArguments, ConversationsOpenArguments, ConversationsRenameArguments, ConversationsRepliesArguments, ConversationsSetPurposeArguments, ConversationsSetTopicArguments, ConversationsUnarchiveArguments } from './conversations';
21+
export type { ChatDeleteArguments, ChatDeleteScheduledMessageArguments, ChatGetPermalinkArguments, ChatMeMessageArguments, ChatPostEphemeralArguments, ChatPostMessageArguments, ChatScheduleMessageArguments, ChatScheduledMessagesListArguments, ChatUnfurlArguments, ChatUpdateArguments } from './chat';
22+
export type { CanvasesAccessDeleteArguments, CanvasesAccessSetArguments, CanvasesCreateArguments, CanvasesDeleteArguments, CanvasesEditArguments, CanvasesSectionsLookupArguments, ConversationsCanvasesCreateArguments } from './canvas';
23+
export type { CallsAddArguments, CallsEndArguments, CallsInfoArguments, CallsUpdateArguments, CallsParticipantsAddArguments, CallsParticipantsRemoveArguments } from './calls';
24+
export type { BotsInfoArguments } from './bots';
25+
export type { BookmarksAddArguments, BookmarksEditArguments, BookmarksListArguments, BookmarksRemoveArguments } from './bookmarks';
26+
export type { AuthRevokeArguments, AuthTestArguments, AuthTeamsListArguments } from './auth';
27+
export type { AppsConnectionsOpenArguments, AppsEventAuthorizationsListArguments, AppsManifestCreateArguments, AppsManifestDeleteArguments, AppsManifestExportArguments, AppsManifestUpdateArguments, AppsManifestValidateArguments, AppsUninstallArguments } from './apps';
28+
export type { APITestArguments } from './api';
29+
export type { AdminAnalyticsGetFileArguments } from './admin/analytics';
30+
export type { AdminAppsActivitiesListArguments, AdminAppsApproveArguments, AdminAppsApprovedListArguments, AdminAppsClearResolutionArguments, AdminAppsConfigLookupArguments, AdminAppsConfigSetArguments, AdminAppsRequestsCancelArguments, AdminAppsRequestsListArguments, AdminAppsRestrictArguments, AdminAppsRestrictedListArguments, AdminAppsUninstallArguments } from './admin/apps';
31+
export type { AdminAuthPolicyAssignEntitiesArguments, AdminAuthPolicyGetEntitiesArguments, AdminAuthPolicyRemoveEntitiesArguments } from './admin/auth';
32+
export type { AdminBarriersCreateArguments, AdminBarriersDeleteArguments, AdminBarriersListArguments, AdminBarriersUpdateArguments } from './admin/barriers';
33+
export type { AdminConversationsArchiveArguments, AdminConversationsBulkArchiveArguments, AdminConversationsBulkDeleteArguments, AdminConversationsBulkMoveArguments, AdminConversationsConvertToPrivateArguments, AdminConversationsConvertToPublicArguments, AdminConversationsCreateArguments, AdminConversationsDeleteArguments, AdminConversationsDisconnectSharedArguments, AdminConversationsEKMListOriginalConnectedChannelInfoArguments, AdminConversationsGetConversationPrefsArguments, AdminConversationsGetCustomRetentionArguments, AdminConversationsGetTeamsArguments, AdminConversationsInviteArguments, AdminConversationsLookupArguments, AdminConversationsRemoveCustomRetentionArguments, AdminConversationsRenameArguments, AdminConversationsRestrictAccessAddGroupArguments, AdminConversationsRestrictAccessListGroupsArguments, AdminConversationsRestrictAccessRemoveGroupArguments, AdminConversationsSearchArguments, AdminConversationsSetConversationPrefsArguments, AdminConversationsSetCustomRetentionArguments, AdminConversationsSetTeamsArguments, AdminConversationsUnarchiveArguments } from './admin/conversations';
34+
export type { AdminEmojiAddArguments, AdminEmojiAddAliasArguments, AdminEmojiListArguments, AdminEmojiRemoveArguments, AdminEmojiRenameArguments } from './admin/emoji';
35+
export type { AdminFunctionsListArguments, AdminFunctionsPermissionsLookupArguments, AdminFunctionsPermissionsSetArguments } from './admin/functions';
36+
export type { FunctionsCompleteErrorArguments, FunctionsCompleteSuccessArguments } from './functions';
37+
export type { AdminInviteRequestsApproveArguments, AdminInviteRequestsApprovedListArguments, AdminInviteRequestsDeniedListArguments, AdminInviteRequestsDenyArguments, AdminInviteRequestsListArguments } from './admin/inviteRequests';
38+
export type { AdminRolesAddAssignmentsArguments, AdminRolesListAssignmentsArguments, AdminRolesRemoveAssignmentsArguments } from './admin/roles';
39+
export type { AdminTeamsAdminsListArguments, AdminTeamsCreateArguments, AdminTeamsListArguments, AdminTeamsOwnersListArguments, AdminTeamsSettingsInfoArguments, AdminTeamsSettingsSetDefaultChannelsArguments, AdminTeamsSettingsSetDescriptionArguments, AdminTeamsSettingsSetDiscoverabilityArguments, AdminTeamsSettingsSetIconArguments, AdminTeamsSettingsSetNameArguments } from './admin/teams';
40+
export type { AdminUsergroupsAddChannelsArguments, AdminUsergroupsAddTeamsArguments, AdminUsergroupsListChannelsArguments, AdminUsergroupsRemoveChannelsArguments } from './admin/usergroups';
41+
export type { AdminUsersAssignArguments, AdminUsersInviteArguments, AdminUsersListArguments, AdminUsersRemoveArguments, AdminUsersSessionListArguments, AdminUsersSessionClearSettingsArguments, AdminUsersSessionGetSettingsArguments, AdminUsersSessionInvalidateArguments, AdminUsersSessionResetArguments, AdminUsersSessionResetBulkArguments, AdminUsersSessionSetSettingsArguments, AdminUsersSetAdminArguments, AdminUsersSetExpirationArguments, AdminUsersSetOwnerArguments, AdminUsersSetRegularArguments, AdminUsersUnsupportedVersionsExportArguments } from './admin/users';
42+
export type { AdminWorkflowsCollaboratorsAddArguments, AdminWorkflowsCollaboratorsRemoveArguments, AdminWorkflowsPermissionsLookupArguments, AdminWorkflowsSearchArguments, AdminWorkflowsUnpublishArguments } from './admin/workflows';

‎packages/web-api/test/integration/ts-4.7-project/index.ts

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
import { WebClient } from '../../../src/index';
2+
new WebClient('invalid-token');

‎packages/web-api/test/integration/ts-4.7-project/package.json

+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
{
2+
"name": "ts-47-project",
3+
"version": "1.0.0",
4+
"description": "",
5+
"scripts": {
6+
"build": "shx rm -rf ./dist && tsc"
7+
},
8+
"devDependencies": {
9+
"shx": "0.3.2",
10+
"typescript": "4.7.2"
11+
},
12+
"keywords": [],
13+
"author": "",
14+
"license": "ISC"
15+
}

‎packages/web-api/test/integration/ts-4.7-project/tsconfig.json

+24
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
{
2+
"compilerOptions": {
3+
"target": "es2017",
4+
"module": "commonjs",
5+
"declaration": true,
6+
"declarationMap": true,
7+
"sourceMap": true,
8+
"outDir": "dist",
9+
10+
"strict": true,
11+
"noUnusedLocals": true,
12+
"noUnusedParameters": true,
13+
"noImplicitReturns": true,
14+
"noFallthroughCasesInSwitch": true,
15+
16+
"moduleResolution": "node",
17+
"baseUrl": ".",
18+
"esModuleInterop" : true,
19+
"resolveJsonModule": true
20+
},
21+
"include": [
22+
"index.ts"
23+
]
24+
}

0 commit comments

Comments
 (0)
Please sign in to comment.