Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files to view.state.values in TS #1995

Merged
merged 1 commit into from Nov 15, 2023
Merged

Conversation

seratch
Copy link
Member

@seratch seratch commented Nov 15, 2023

Summary

This pull request adds a new value to view.state.values data structure for view_submission request patterns. See https://api.slack.com/reference/block-kit/block-elements#file_input for details of the new file_input block element.

Requirements (place an x in each [ ])

@seratch seratch added enhancement M-T: A feature request for new functionality TypeScript-specific labels Nov 15, 2023
@seratch seratch added this to the 3.15.0 milestone Nov 15, 2023
@seratch seratch requested a review from filmaj November 15, 2023 04:14
@seratch seratch self-assigned this Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad14372) 82.21% compared to head (2e9dd3c) 82.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1995   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files          18       18           
  Lines        1524     1524           
  Branches      438      438           
=======================================
  Hits         1253     1253           
  Misses        175      175           
  Partials       96       96           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@filmaj filmaj merged commit a3c679a into slackapi:main Nov 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants