From e0dddaa988afdecdc9c965b94cb3925903d36e1f Mon Sep 17 00:00:00 2001 From: Ethan Zimbelman Date: Mon, 28 Aug 2023 11:31:24 -0700 Subject: [PATCH 1/3] remove deprecated codecov dependency --- .github/workflows/ci-build.yml | 1 - package.json | 2 -- 2 files changed, 3 deletions(-) diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml index b1822ed30..1c53208d7 100644 --- a/.github/workflows/ci-build.yml +++ b/.github/workflows/ci-build.yml @@ -29,4 +29,3 @@ jobs: run: ./node_modules/.bin/eslint -v - run: npm run build - run: npm test - - run: npm run coverage diff --git a/package.json b/package.json index 1cfbe1982..1b3ed2bcd 100644 --- a/package.json +++ b/package.json @@ -32,7 +32,6 @@ "mocha": "TS_NODE_PROJECT=tsconfig.json nyc mocha --config .mocharc.json \"src/**/*.spec.ts\"", "test": "npm run lint && npm run mocha && npm run test:types", "test:types": "tsd", - "coverage": "codecov", "watch": "npx nodemon --watch 'src' --ext 'ts' --exec npm run build" }, "repository": "slackapi/bolt", @@ -65,7 +64,6 @@ "@typescript-eslint/eslint-plugin": "^4.4.1", "@typescript-eslint/parser": "^4.4.0", "chai": "^4.2.0", - "codecov": "^3.2.0", "eslint": "^7.26.0", "eslint-config-airbnb-base": "^14.2.1", "eslint-config-airbnb-typescript": "^12.3.1", From 4448cae9aad7ce396991c7e08291820325ac9067 Mon Sep 17 00:00:00 2001 From: Ethan Zimbelman Date: Mon, 28 Aug 2023 11:31:52 -0700 Subject: [PATCH 2/3] add codecov github action to ci-build --- .github/workflows/ci-build.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml index 1c53208d7..cda3eaee4 100644 --- a/.github/workflows/ci-build.yml +++ b/.github/workflows/ci-build.yml @@ -29,3 +29,9 @@ jobs: run: ./node_modules/.bin/eslint -v - run: npm run build - run: npm test + - name: Upload coverage to Codecov + uses: codecov/codecov-action@v3 + with: + directory: coverage + fail_ci_if_error: true + verbose: true From 1215aa78abdc1cd94ea0ad93dc7a9a51de775376 Mon Sep 17 00:00:00 2001 From: Ethan Zimbelman Date: Mon, 28 Aug 2023 11:50:57 -0700 Subject: [PATCH 3/3] only upload coverage reports for node 20.x --- .github/workflows/ci-build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml index cda3eaee4..8586dafaf 100644 --- a/.github/workflows/ci-build.yml +++ b/.github/workflows/ci-build.yml @@ -30,6 +30,7 @@ jobs: - run: npm run build - run: npm test - name: Upload coverage to Codecov + if: matrix.node-version == '20.x' uses: codecov/codecov-action@v3 with: directory: coverage