-
-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SinonFakeServer.respondWith not working with query params on 17.0.2 #2596
Comments
We've been blocked by this issue, too. I noticed that the issue is caused by sinonjs/nise#216. Rewriting all the usages of |
Thanks for providing this. This bug is totally on me. I am not sure how I missed James' very detailed explanations in his PR, which spells out how this is a breaking change and actually asks for input (which I also missed, must have been late). My suggestion:
Thoughts, @43081j or @mroderick ? |
An interim "fix" is that I rolled the |
i think that makes sense. let me know if you want any help sorting the new flag out etc doesn't sound too difficult. basically default it to legacy behaviour which auto-escapes |
The code repro is unfortunately not runnable (suggest using RunKit next time), so I have no 100% assurance this is fixed, but it should be fixed in the changes James shipped to Nise (enabling the legacy routes flag by default) should mean this is gone. Please test Sinon 18 and report back if this is not fixed. |
Describe the bug
the
respondWith
seems to not work when the URL has a?
To Reproduce
Steps to reproduce the behavior:
I have this
the code is breaking when
server.respondWith
is being calledthe error is
Context (please complete the following information):
The text was updated successfully, but these errors were encountered: