Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mocha watch task by delegating to Node #2573

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

fatso83
Copy link
Contributor

@fatso83 fatso83 commented Nov 7, 2023

Since Node 18 there is a built-in watch mode. Mocha's watch
mode is really buggy and this fix is much snappier and
bug-free AFAIK.

Purpose (TL;DR) - mandatory

How to verify - mandatory

  1. Check out this branch
  2. npm install

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

Since Node 18 there is a built-in watch mode. Mocha's watch
mode is really buggy and this fix is much snappier and
bug-free AFAIK.
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45c4d6b) 96.02% compared to head (80b9289) 96.02%.
Report is 1 commits behind head on main.

❗ Current head 80b9289 differs from pull request most recent head a9ce9eb. Consider uploading reports for the commit a9ce9eb to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2573   +/-   ##
=======================================
  Coverage   96.02%   96.02%           
=======================================
  Files          40       40           
  Lines        1912     1912           
=======================================
  Hits         1836     1836           
  Misses         76       76           
Flag Coverage Δ
unit 96.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fatso83 fatso83 merged commit adcf936 into main Nov 7, 2023
10 checks passed
@fatso83 fatso83 deleted the watch-runner-fix branch November 7, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant