Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mochify breaking on node:assert #2559

Merged
merged 2 commits into from Oct 24, 2023

Conversation

fatso83
Copy link
Contributor

@fatso83 fatso83 commented Oct 24, 2023

Purpose (TL;DR) - mandatory

Fix mochify borking on node:assert

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8dbfd02) 96.03% compared to head (ea8ad15) 96.03%.
Report is 1 commits behind head on main.

❗ Current head ea8ad15 differs from pull request most recent head 44529c8. Consider uploading reports for the commit 44529c8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2559   +/-   ##
=======================================
  Coverage   96.03%   96.03%           
=======================================
  Files          40       41    +1     
  Lines        1915     1918    +3     
=======================================
+ Hits         1839     1842    +3     
  Misses         76       76           
Flag Coverage Δ
unit 96.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/create-sinon-api.js 100.00% <100.00%> (ø)
lib/sinon.js 100.00% <100.00%> (ø)
lib/sinon/colorizer.js 100.00% <ø> (ø)
lib/sinon/spy-formatters.js 98.55% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fatso83 fatso83 merged commit 4f538e3 into sinonjs:main Oct 24, 2023
7 checks passed
@fatso83 fatso83 deleted the fix-broken-node-assert branch October 24, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant