Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only force new or inherited descriptors to be configurable #2515

Merged
merged 1 commit into from May 18, 2023
Merged

Conversation

fatso83
Copy link
Contributor

@fatso83 fatso83 commented May 16, 2023

Purpose (TL;DR) - mandatory

Fixes the regression introduced in 15.0.4 and documented as #2514.

Regression test added.

@fatso83 fatso83 changed the title only force new or inherited descriptors to be configurable Only force new or inherited descriptors to be configurable May 16, 2023
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b2a4df5) 95.99% compared to head (acd205a) 96.00%.

❗ Current head acd205a differs from pull request most recent head a6333f4. Consider uploading reports for the commit a6333f4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2515   +/-   ##
=======================================
  Coverage   95.99%   96.00%           
=======================================
  Files          40       40           
  Lines        1899     1900    +1     
=======================================
+ Hits         1823     1824    +1     
  Misses         76       76           
Flag Coverage Δ
unit 96.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/sinon/util/core/wrap-method.js 82.52% <100.00%> (+0.17%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fatso83 fatso83 merged commit f096abf into main May 18, 2023
11 checks passed
@fatso83 fatso83 deleted the fix-2514 branch May 18, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant