Add unimported to workflow #2441
Conversation
The last reference to this file was removed in 6b1841f, making it safe to remove
This has only been in use by tests since e37e1a6, so doesn't belong in the src/ folder anymore
Searching the git history, we find that the last reference to this file was removed with e37e1a6. ``` git log -p --full-history --all -G'require.*restore"' li ``` Therefore, it is safe to remove the file.
This allows us to find files that are no longer in use in the project and can be safely removed. See https://github.com/smeijer/unimported
Codecov Report
@@ Coverage Diff @@
## master #2441 +/- ##
==========================================
- Coverage 96.01% 95.97% -0.04%
==========================================
Files 41 39 -2
Lines 1906 1888 -18
==========================================
- Hits 1830 1812 -18
Misses 76 76
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Thank you for merging this @fatso83! It was a bit fast, as I had a |
|
Hmm ... not sure I follow. A fixup commit is supposed to be squashed with the previous when rebasing, right? And since all commits were squashed, the effect should be the same ... Or? 😬 |
|
Nice |
|
Project |
|
@mroderick I blocked this account after the bottish behavior in #2441 #2444 and #2445. |
This PR adds a check for unimported files to the GitHub Actions workflow, using https://github.com/smeijer/unimported
As always, the PR is easier to understand when you read the commits individually.
How to verify
lib/that is not usednpm run unimportednpm run unimported