.github/workflows/main.yml

@@ -47,25 +47,8 @@ jobs:
         run: |
           npm run lint
 
-  unused:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v4
-        with:
-          node-version: "lts/*"
-          cache: "npm"
-      - name: Install dependencies
-        run: |
-          npm ci
-        env:
-          PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: 1
-      - name: Find unused files
-        run: |
-          npm run unimported
-
   browser-test:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
@@ -88,6 +71,8 @@ jobs:
           npm run test-webworker -- --chrome $SINON_CHROME_BIN --allow-chrome-as-root
           npm run test-esm-browser-build
       - name: Upload coverage report
+        env:
+          CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
         run: bash <(curl -s https://codecov.io/bash) -F unit -s coverage/lcov.info
 
   saucelabs-test:

CHANGES.md

@@ -1,5 +1,105 @@
 # Changes
 
+## 19.0.3
+
+Basically just documentation updates
+
+- [`1f1d3706`](https://github.com/sinonjs/sinon/commit/1f1d3706c07e70fc29b111844025c74e48f83284)
+  Verifying links procedure (Carl-Erik Kopseng)
+- [`37623efc`](https://github.com/sinonjs/sinon/commit/37623efc5118f1eeb9a7df28694997412bcd38b1)
+  Catch latest two missing redirects (Carl-Erik Kopseng)
+- [`2404a45f`](https://github.com/sinonjs/sinon/commit/2404a45feeae904a286b3d6321d22ef2cdb08e93)
+  Ignore ancient deadlinks to Sinon child projects in previous releases (Carl-Erik Kopseng)
+- [`fba6f877`](https://github.com/sinonjs/sinon/commit/fba6f877b04a1ced5533c050724ecc4e9aba9df6)
+  Ignore historic links in changelog (Carl-Erik Kopseng)
+- [`e3950d9b`](https://github.com/sinonjs/sinon/commit/e3950d9b391b26e684a1add77da2f70fdd1cdc6d)
+  Fix external link (Carl-Erik Kopseng)
+- [`0be40825`](https://github.com/sinonjs/sinon/commit/0be4082548f206e0e6f2b02b84b190e04e137fd1)
+  Fix the missing redirects to the migration guide (Carl-Erik Kopseng)
+- [`108fbca0`](https://github.com/sinonjs/sinon/commit/108fbca09ccccac6521ba48fd4030a762d498e11)
+  Fix internal ../assertions link in source (Carl-Erik Kopseng)
+- [`bb10e53a`](https://github.com/sinonjs/sinon/commit/bb10e53a905a60cca2d2ec59d2205e8453214899)
+  Fix spy-call reference in source (Carl-Erik Kopseng)
+- [`ef582e31`](https://github.com/sinonjs/sinon/commit/ef582e319a89ced90c5c259657900aa4cf2c88b5)
+  Remove bash-ism from Makefile (use POSIX) (Carl-Erik Kopseng)
+- [`7af1d235`](https://github.com/sinonjs/sinon/commit/7af1d23581d2c8c7625e248a9bdfb2767f12ef98)
+  chore: remove .unimportedrc.json (Morgan Roderick)
+- [`dfcad710`](https://github.com/sinonjs/sinon/commit/dfcad71008a751f151063d7a739590e847a338d9)
+  chore: fix codecov upload (Morgan Roderick)
+  > We are seeing errors uploading coverage reports to codecov:
+  >
+  > ```
+  > Rate limit reached. Please upload with the Codecov repository upload token to resolve issue
+  > ```
+  >
+  > I've added a repository token, as instructed in https://docs.codecov.com/docs/adding-the-codecov-token.
+  >
+  > This changeset should fix the upload issue.
+- [`0ca2e49e`](https://github.com/sinonjs/sinon/commit/0ca2e49e857ec6b10ed4134944cdf591a0065965)
+  fix: browser-test job fails in ubuntu-latest (Morgan Roderick)
+- [`e9eb2eb2`](https://github.com/sinonjs/sinon/commit/e9eb2eb26e873f106a9996610a142d25d917d9e8)
+  chore: remove unused unused job (Morgan Roderick)
+  > This crucial part of this workflow was removed in
+  > 278e667e095cd1a666c3ab2dc4268379a5754598, we should have removed the entire job.
+- [`278e667e`](https://github.com/sinonjs/sinon/commit/278e667e095cd1a666c3ab2dc4268379a5754598)
+  chore: remove unimported (Morgan Roderick)
+  > The repository has been archived. See https://github.com/smeijer/unimported
+- [`9e30835b`](https://github.com/sinonjs/sinon/commit/9e30835bb7c7bb550ed299a4102fdd53a23b083f)
+  npm audit (Morgan Roderick)
+- [`a74301cf`](https://github.com/sinonjs/sinon/commit/a74301cff8e7fb42ebb164c91d059ab391741473)
+  chore: remove RunKit (Morgan Roderick)
+  > This service is dead.
+- [`80bc1d96`](https://github.com/sinonjs/sinon/commit/80bc1d96371580a8b2dad39122db46933e7f5884)
+  Fix out-of-date fake-timers docs (#2628) (Carl-Erik Kopseng)
+  > - Fix documentation issue for fake-timers mentioned in #2625
+  >
+  > The docs were out of sync with the fake-timers docs.
+  >
+  > - Update dependencies before new patch version
+- [`527568cc`](https://github.com/sinonjs/sinon/commit/527568cc60a3c30359732bbb02806cee47a33d02)
+  Bump rexml from 3.3.7 to 3.3.9 (#2626) (dependabot[bot])
+  > Bumps [rexml](https://github.com/ruby/rexml) from 3.3.7 to 3.3.9.
+  >
+  > - [Release notes](https://github.com/ruby/rexml/releases)
+  > - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md)
+  > - [Commits](https://github.com/ruby/rexml/compare/v3.3.7...v3.3.9)
+  >
+  > ***
+  >
+  > updated-dependencies:
+  >
+  > - dependency-name: rexml
+  >
+  >   dependency-type: indirect
+  >
+  > ...
+  >
+  > Signed-off-by: dependabot[bot] <support@github.com>
+  >
+  > Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
+- [`ed029725`](https://github.com/sinonjs/sinon/commit/ed0297257413b728bc31515ac0a87e738e069961)
+  Bump webrick from 1.8.1 to 1.8.2 (#2623) (dependabot[bot])
+  > Bumps [webrick](https://github.com/ruby/webrick) from 1.8.1 to 1.8.2.
+  >
+  > - [Release notes](https://github.com/ruby/webrick/releases)
+  > - [Commits](https://github.com/ruby/webrick/compare/v1.8.1...v1.8.2)
+  >
+  > ***
+  >
+  > updated-dependencies:
+  >
+  > - dependency-name: webrick
+  >
+  >   dependency-type: indirect
+  >
+  > ...
+  >
+  > Signed-off-by: dependabot[bot] <support@github.com>
+  >
+  > Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
+
+_Released by Carl-Erik Kopseng on 2025-03-19._
+
 ## 19.0.2
 
 - [`4eb4c4bc`](https://github.com/sinonjs/sinon/commit/4eb4c4bc0266d90d1624e5067029599ed57f7fb2)

Gemfile

@@ -4,3 +4,4 @@ gem "jekyll", "~> 3.7"
 gem 'jekyll-sitemap'
 gem 'jekyll-toc'
 gem 'html-proofer'
+gem 'jekyll-redirect-from'

Gemfile.lock

@@ -295,7 +295,7 @@ GEM
     rb-fsevent (0.11.2)
     rb-inotify (0.11.1)
       ffi (~> 1.0)
-    rexml (3.3.7)
+    rexml (3.3.9)
     rouge (3.30.0)
     ruby-rc4 (0.1.5)
     rubyzip (2.3.2)
@@ -320,7 +320,7 @@ GEM
       concurrent-ruby (~> 1.0)
     unicode-display_width (1.8.0)
     uri (0.13.1)
-    webrick (1.8.1)
+    webrick (1.8.2)
     yell (2.2.2)
     zeitwerk (2.6.18)
 
@@ -344,6 +344,7 @@ DEPENDENCIES
   github-pages
   html-proofer
   jekyll (~> 3.7)
+  jekyll-redirect-from
   jekyll-sitemap
   jekyll-toc
 

docs/Makefile

@@ -14,21 +14,25 @@ install:
 	@make check-dependencies
 
 copy-over-sinon-script:
-	@[[ -e assets/js/sinon.js ]] || npm run build && cp ../pkg/sinon.js assets/js/
+	@[ -e assets/js/sinon.js ] || npm run build && cp ../pkg/sinon.js assets/js/
 
 check-dependencies:
 	@command -v git-lfs > /dev/null || (make print S="You need to install Git LFS before committing changes" && exit 1)
 
 check-links: copy-over-sinon-script
-	bundle exec htmlproofer --assume-extension='.html' --ignore-status-codes="403" --no-enforce-https ./_site/
+	bundle exec htmlproofer --assume-extension='.html' \
+        --ignore-status-codes="403" \
+        --ignore-files=./_site/releases/changelog.html \
+        --ignore-urls=/github.com/sinonjs/lolex.*/,/busterjs.org/ \
+        --no-enforce-https ./_site/
 
 deploy: check-dependencies
 	git push
 
 livereload:
-	bundle exec jekyll serve --trace --livereload --host localhost  --incremental
+	bundle exec jekyll serve --trace --livereload --host localhost  --incremental --safe
 
-# only for checking out the final build
+# only for checking out the final build and/or validating links (also works with livereload)
 # # only for checking out the final build
 build:
 	bundle exec jekyll build

docs/README.md

@@ -18,3 +18,17 @@ Currently, we keep a single folder per major release.
 See `scripts/postversion.sh` for details on the exact process, as it changes over time.
 
 The release is packaged, tagged and pushed to GitHub. GitHub Pages will build a new site in a few minutes, and replace the old one.
+
+## Verifying links
+
+This has yet to be automated (requires some Rubys setup), but you can use the Makefile target `check-links` to verify internal
+and external links, which were all verified per March 2025.
+
+```bash
+git checkout releases
+make install
+make build
+make check-links
+```
+
+You might need to fiddle a bit around with locally merging in changes from whatever branch you are on to check those changes, but it's quite doable.

docs/_config.yml

@@ -5,7 +5,7 @@ description: >-
 url: 'https://sinonjs.org'
 github_username: sinonjs
 sinon:
-  current_release: v19.0.2
+  current_release: v19.0.3
   current_major_version: 19
 markdown: kramdown
 kramdown:
@@ -18,6 +18,8 @@ plugins:
   - jekyll-redirect-from
   - jekyll-sitemap
   - jekyll-toc
+whitelist:
+  - jekyll-redirect-from
 keep_files:
   - assets
   - releases

docs/_includes/footer.html

@@ -1,6 +1,4 @@
 <script src="{{ "/assets/js/prism.js" | prepend: site.baseurl }}"></script>
-<script src="https://embed.runkit.com"></script>
-{% include embed-scripts.html %}
 
 <div class="footer">
   <div class="container text-center">