Pass responseType for defaked XHR #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mad-gooze
commented
Apr 16, 2018
| @@ -190,9 +194,15 @@ FakeXMLHttpRequest.defake = function defake(fakeXhr, xhrArgs) { | |||
| copyAttrs(["status", "statusText"]); | |||
| } | |||
| if (xhr.readyState >= FakeXMLHttpRequest.LOADING) { | |||
| copyAttrs(["responseText", "response"]); | |||
| copyAttrs(["response"]); | |||
| if (xhr.responseType === "" || xhr.responseType === "text") { | |||
There was a problem hiding this comment.
responseText can be accessed only for text responses
mad-gooze
commented
Apr 16, 2018
| if (xhr.readyState === FakeXMLHttpRequest.DONE) { | ||
| if ( | ||
| xhr.readyState === FakeXMLHttpRequest.DONE && | ||
| (xhr.responseType === "" || xhr.responseType === "document") |
There was a problem hiding this comment.
responseXML can be accessed only for XML responses
|
@mroderick could you have a look please? |
fatso83
approved these changes
Jun 1, 2018
|
Thank you! Sorry for having this lingering so long. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
responseTypeis not passed to original XHR object after callingdefake. This causes unexpected type ofxhr.responsewhen sending defaked requests withresponseType = "arraybuffer"(response is a string instead of ArrayBuffer).