Ugrade lolex to v5 and don't detect globals #108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integrates the latest lolex and introduces the
--no-detect-globals
flag for browserify bundles and tests.There is also a solution for running the tests using JSDOM on node and the actual DOM in headless chrome.
Note that we used to browserify
jsdom
,jsdom-global
and@sinonjs/text-encoding
. Putting those on the ignore list speeds up test runs significantly.The
global-hack.js
thing is needed due to the circular dependencies that we have. Once Sinon includes all the latest, this can be removed.