Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ugrade lolex to v5 and don't detect globals #108

Merged
merged 1 commit into from Oct 14, 2019
Merged

Conversation

mantoni
Copy link
Member

@mantoni mantoni commented Oct 11, 2019

This integrates the latest lolex and introduces the --no-detect-globals flag for browserify bundles and tests.

There is also a solution for running the tests using JSDOM on node and the actual DOM in headless chrome.

Note that we used to browserify jsdom, jsdom-global and @sinonjs/text-encoding. Putting those on the ignore list speeds up test runs significantly.

The global-hack.js thing is needed due to the circular dependencies that we have. Once Sinon includes all the latest, this can be removed.

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #108 into master will decrease coverage by 0.28%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   90.86%   90.57%   -0.29%     
==========================================
  Files          12       13       +1     
  Lines         602      605       +3     
==========================================
+ Hits          547      548       +1     
- Misses         55       57       +2
Flag Coverage Δ
#unit 90.57% <66.66%> (-0.29%) ⬇️
Impacted Files Coverage Δ
test/global-hack.js 0% <0%> (ø)
lib/fake-xhr/index.js 86.95% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff9b43d...0a81369. Read the comment docs.

@mantoni
Copy link
Member Author

mantoni commented Oct 11, 2019

Hm. We don't run test:headless on CI yet 🤔

@mroderick
Copy link
Member

That should be an easy fix

package.json Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants