Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency "decode-uri-component": "^0.2.0" contains vulnerability #350

Closed
danisluk opened this issue Nov 29, 2022 · 6 comments · Fixed by #353
Closed

Dependency "decode-uri-component": "^0.2.0" contains vulnerability #350

danisluk opened this issue Nov 29, 2022 · 6 comments · Fixed by #353

Comments

@danisluk
Copy link

Unmaintained library decode-uri-component contains quite severe vulnerability.
GHSA-w573-4hg7-7wgq
Any chance, this could be fixed here possibly by replacing the lib?

@MasterJuan
Copy link

Also, npm audit fix proposes the below change:

Will install **query-string@4.3.4**, which is a breaking change
node_modules/decode-uri-component
  query-string  >=5.0.0
  Depends on vulnerable versions of decode-uri-component
  node_modules/query-string

So, actually proposes a downgrade of query-string version.

Instead of using decode-uri-component can you replace it with https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/decodeURIComponent

@redonkulus
Copy link

@sindresorhus what do you suggest to mitigate this vulnerability?

@ryanadhi
Copy link

ryanadhi commented Dec 1, 2022

seems like a fix is on the way on decode-uri-component SamVerschueren/decode-uri-component#6 (comment)

@MattTranGrainbridge
Copy link

Fix released for decode-uri-component: https://github.com/SamVerschueren/decode-uri-component/releases/tag/v0.2.1

@taejs
Copy link

taejs commented Dec 2, 2022

@viczhuravlev
@sindresorhus
@rawle51

Hi
query-string@5 is EOL?
I just wonder there's any plan to also apply this changes to v5, v6

I can create PR for this

@sindresorhus
Copy link
Owner

I just wonder there's any plan to also apply this changes to v5, v6

No plans, but it's a patch release, so you should get the latest one there anyways thanks to server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants