Skip to content

Commit 659f839

Browse files
erezrokahsindresorhus
andauthoredJun 8, 2021
Don't allow default as a spinner (#175)
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
1 parent c7d6dba commit 659f839

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed
 

‎index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ class Ora {
168168
} else if (spinner === undefined) {
169169
// Set default spinner
170170
this._spinner = cliSpinners.dots;
171-
} else if (cliSpinners[spinner]) {
171+
} else if (spinner !== 'default' && cliSpinners[spinner]) {
172172
this._spinner = cliSpinners[spinner];
173173
} else {
174174
throw new Error(`There is no built-in spinner named '${spinner}'. See https://github.com/sindresorhus/cli-spinners/blob/main/spinners.json for a full list.`);

‎test.js

+6
Original file line numberDiff line numberDiff line change
@@ -322,6 +322,12 @@ if (process.platform !== 'win32') {
322322
});
323323
}
324324

325+
test('throw when spinner is set to `default`', t => {
326+
t.throws(() => {
327+
new Ora({spinner: 'default'}); // eslint-disable-line no-new
328+
}, /no built-in spinner/);
329+
});
330+
325331
test('indent option', t => {
326332
const stream = getPassThroughStream();
327333
stream.isTTY = true;

0 commit comments

Comments
 (0)