Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore URLs with custom protocols #178

Merged
merged 2 commits into from Nov 4, 2022
Merged

Ignore URLs with custom protocols #178

merged 2 commits into from Nov 4, 2022

Conversation

sindresorhus
Copy link
Owner

Fixes #177
Fixes #152
Closes #153

Breaking changes:

  • ftp is no longer supported.
    • An option can be added where users can provide custom protocols they want normalized.
  • You can no longer pass in a human-friendly URL with auth: user:password@sindresorhus.com
    • This should be fine as basic auth in URL is deprecated anyway.

@sindresorhus
Copy link
Owner Author

// @daKmoR

@daKmoR
Copy link

daKmoR commented Oct 31, 2022

@sindresorhus awesome 🤗 thank you 🙇‍♂️
I tested it and it now works exactly as expected in these situations 💪

which means once this is released I can get rid of my workarounds 😍

@sindresorhus sindresorhus merged commit 882cb84 into main Nov 4, 2022
@sindresorhus sindresorhus deleted the custom-protocols branch November 4, 2022 07:55
@sindresorhus
Copy link
Owner Author

@daKmoR https://github.com/sindresorhus/normalize-url/releases/tag/v8.0.0

@Kilian Kilian mentioned this pull request Mar 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No support for "tel:xxxx", "mailto:xxx" like urls Support custom protocols
2 participants
@sindresorhus @daKmoR