Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x release supporting recent semver? #43

Closed
PeterJCLaw opened this issue Jul 3, 2023 · 2 comments
Closed

3.x release supporting recent semver? #43

PeterJCLaw opened this issue Jul 3, 2023 · 2 comments

Comments

@PeterJCLaw
Copy link

PeterJCLaw commented Jul 3, 2023

I realise that with v4 now being released the 3.x series is no longer the latest, however a number of users are still stuck on the 3.x series due to the Node version requirement. (For my use-case the chain is: cspell 6.x -> configstore 5.x -> make-dir 3.x; each package along the chain has its own reasons for not picking up a major version bump of the dependent package; streetsidesoftware/cspell#4594, yeoman/configstore#89).

As far as I can tell the 6.x to 7.x version bump of semver isn't breaking to the usages in make-dir, so I'm expecting that cherry-picking 777eed3 then releasing a 3.x would suffice. Would you be up for doing that? (I'd be happy to create a PR if that's useful, though given the size of the change I'm assuming it's not particularly so)

@sindresorhus
Copy link
Owner

The semver vulnerability does not apply to make-dir as it does not use semver with untrusted user-input. I understand you want the vulnerability gone from npm audit, but I don't want to waste all my maintainer time on bumping dependencies for "vulnerabilities" that in reality affect no one.

https://overreacted.io/npm-audit-broken-by-design/

@otacke
Copy link

otacke commented Jul 7, 2023

It seems that Nicolò Ribaudo is going to create a pull request to fix the issue in version 6 of semver in order to please npm audit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants