Reject normalization errors with CancelableRequest #1035
Merged
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szmarczak
requested changes
Jan 23, 2020
test/error.ts
Outdated
| @@ -193,6 +193,12 @@ test('errors are thrown directly when options.stream is true', t => { | |||
| }); | |||
| }); | |||
|
|
|||
| test('normalization errors using convenience methods', async t => { | |||
| const error = await t.throwsAsync(got('undefined/https://example.com')); | |||
There was a problem hiding this comment.
Suggested change
| const error = await t.throwsAsync(got('undefined/https://example.com')); | |
| await t.throwsAsync(got('undefined/https://example.com').json().text().buffer(), 'Invalid URL'); |
There was a problem hiding this comment.
You forgot to test .text() and .buffer(). Make sure that the error message is Invalid URL. As in the suggestion.
There was a problem hiding this comment.
Ah, I must have missed the Invalid URL part. Do you want a separate assertion for each method?
|
Looks good, thanks! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1025
In the event of an error being thrown during argument normalization a normal promise was being returned which prevented users from calling any of the CancelableRequest convenience methods. This changes makes it so a rejected CancelableRequest is returned instead.
Checklist